[GROOVY-9288] Compilation error when accessing a protected super class field from inside a closure

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.7, 2.5.8, 3.0.0-rc-1
• Fix Version/s: 3.0.0-rc-2, 2.5.13
• Component/s: Static compilation
• Assignee: Eric Milles
• Reporter: John Bellassai
• Created: 22/Oct/19 20:19
• Updated: 19/Nov/20 18:15
• Resolved: 28/Oct/19 14:42

Description

The following code works fine in 2.5.6 but breaks in 2.5.7 and 2.5.8:

GroovyShell shell = new GroovyShell()
shell.evaluate('''
    package a
    
    import groovy.transform.CompileStatic
    
    @CompileStatic
    abstract class Abstract_Class {
        protected String protectedField = 'field'
        
        abstract String doThing()
    }
    assert true''')

shell.evaluate('''
    package b
    
    import a.Abstract_Class
    import groovy.transform.CompileStatic
    
    @CompileStatic
    class ConcreteClass extends Abstract_Class {
       
        @Override
        String doThing() {
            'something'.with {
                return protectedField
            }
        }
    }
    assert true''')

shell.evaluate("assert new b.ConcreteClass().doThing() == 'field'")

org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
Script2.groovy: 13: Access to a.Abstract_Class#protectedField is forbidden @ line 13, column 32.
                           return protectedField
                                  ^

If you change both classes to be in the same package, you get a runtime error like this:

tried to access field a.Abstract_Class.protectedField from class a.ConcreteClass$_doThing_closure1
java.lang.IllegalAccessError: tried to access field a.Abstract_Class.protectedField from class a.ConcreteClass$_doThing_closure1

Issue Links

• is related to: GROOVY-9292 Compilation error when accessing a protected super class field from a closure using owner, delegate or thisObject qualifier (different package)
• links to: GitHub Pull Request #1046
• links to: GitHub Pull Request #1048