[GROOVY-9266] Extension method metaClass lacks closure metadata for IDE/STC

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.17, 2.5.8, 3.0.0-beta-3
• Fix Version/s: 2.5.9, 3.0.0-rc-1
• Assignee: Eric Milles
• Reporter: Eric Milles
• Created: 02/Oct/19 16:23
• Updated: 24/Nov/19 02:44
• Resolved: 11/Oct/19 13:57

Description

The two "metaClass" methods of DefaultGroovyMethods accept a Closure but do not indicate delegate or parameter metadata.

public static MetaClass metaClass(Class self, Closure closure) ...
public static MetaClass metaClass(Object self, Closure closure) ...

Both methods pass the closure to ExpandoMetaClass.define which also lacks metadata. Here is the proposed change to that method, which could be propagated to the DGMs:

    public ExpandoMetaClass define(@ClosureParams(value=SimpleType.class, options="java.lang.Object")
            @DelegatesTo(value=DefiningClosure.class, strategy=Closure.DELEGATE_ONLY) Closure closure) {
        final DefiningClosure definer = new DefiningClosure();
        Object delegate = closure.getDelegate();
        closure.setDelegate(definer);
        closure.setResolveStrategy(Closure.DELEGATE_ONLY);
        closure.call((Object)null);
        closure.setDelegate(delegate);
        closure.setResolveStrategy(Closure.DELEGATE_FIRST);
        definer.definition = false;
        return this;
    }

Note: Not sure exactly how to indicate that the parameter is "null" or if that's important.

Issue Links

• links to: GitHub Pull Request #1015