[GROOVY-9236] Avoid unnecessary resolving

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-rc-1
• Assignee: Daniel Sun
• Reporter: Daniel Sun
• Created: 29/Aug/19 06:45
• Updated: 24/Nov/19 02:44
• Resolved: 11/Sep/19 05:07

Description

ResolveVisitor's resolveFromStaticInnerClasses, resolveFromDefaultImports and resolveNestedClass will try to guess class qualified name and load. In the process of resolving, lots of time wasted on finding non-existing classes. So we should try to resolve classes in a determined manner.

For example,
For java.util.stream.Collectors, ① resolveFromStaticInnerClasses will try to guess java.util.stream$Collectors, java.util$stream$Collectors, java$util$stream$Collectors.
And ② resolveFromDefaultImports will guess java.lang.java$util$stream$Collectors, java.util.java$util$stream$Collectors, ..., groovy.lang.java$util$stream$Collectors.

After the precedence of resolving adjusted, the above unnecessary resolving can be avoided.

See the discussion in the dev mailing list: http://groovy.329449.n5.nabble.com/Performance-of-the-compiler-tt5750989.html
and its attachment: http://groovy.329449.n5.nabble.com/attachment/5750989/0/CPU-hot-spots.txt

Issue Links

• links to: GitHub Pull Request #998