[GROOVY-9195] STC: mixed checking for access to non-public fields

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-rc-2
• Assignee: Eric Milles
• Reporter: Eric Milles
• Created: 16/Jul/19 16:02
• Updated: 09/Dec/19 21:35
• Resolved: 30/Oct/19 08:20

Description

Follow up to GROOVY-8999, GROOVY-9093 and GROOVY-9136. Consider the following:

class Foo {
  private String field = 'value'
}
class Bar {
  @groovy.transform.CompileStatic
  void test(Foo foo) {
    foo.with {
      field // Access to Foo#field is forbidden
    }
  }
}

class Foo {
  private String field = 'value'
}
class Bar {
  @groovy.transform.CompileStatic
  void test(Foo foo) {
    println foo.field
  }
}
new Bar().test(new Foo()) // prints "value"

Since STC produces an error for access to Foo.field as variable expression, I would expect the same error for access to the field through property expression. Same goes for protected and package-private with the appropriate package separation of Foo and Bar.

Issue Links

• links to: GitHub Pull Request #1052