[GROOVY-9153] StaticInvocationWriter modifies shared global node ConstantExpression.NULL

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.8, 3.0.0-beta-2
• Assignee: Daniel Sun
• Reporter: Eric Milles
• Created: 30/May/19 16:43
• Updated: 06/Aug/19 11:19
• Resolved: 04/Jun/19 10:51

Description

In the case of a static groovy method call like File.createTempDir() when @CompileStatic is applied, StaticInvocationWriter's writeDirectMethodCall and loadArguments mutate the shared global constant node ConstantExpression.NULL.

Relevant bits:

    protected boolean writeDirectMethodCall(final MethodNode target, final boolean implicitThis, final Expression receiver, final TupleExpression args) {
        ...
        if (target instanceof ExtensionMethodNode) {
            ...
            if (emn.isStaticExtension()) {
                // it's a static extension method
                argumentList.add(0, ConstantExpression.NULL);
            } else {
                ....
            }

            Parameter[] parameters = node.getParameters();
            loadArguments(argumentList, parameters);
...
    protected void loadArguments(List<Expression> argumentList, Parameter[] para) {
        ...
                // This is repeated 3 times in the method:
                Expression expression = argumentList.get(i);
                expression.putNodeMetaData(PARAMETER_TYPE, para[i].getType());

Issue Links

• links to: GitHub Pull Request #947