[GROOVY-9112] Clean bad smell in `GroovyClassLoader`

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-beta-2
• Labels: breaking
• Assignee: Daniel Sun
• Reporter: Daniel Sun
• Created: 07/May/19 15:08
• Updated: 10/May/19 14:56
• Resolved: 10/May/19 14:56

Description

The type of classCache can not represent its true responsibility:
protected final Map<String, Class> classCache = new UnlimitedConcurrentCache<String, Class>();

So I propose to change the type to EvictableCache<String, Class>

Similarly,  protected final Map<String, Class> sourceCache = new StampedCommonCache<String, Class>(); has the same bad smell

It will be a breaking change, but it is time to clean the historical bad smell in a big version like Groovy 3.0.0

Issue Links

• links to: GitHub Pull Request #926