[GROOVY-8965] instanceof with || inserts wrong cast

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.5
• Fix Version/s: 4.0.5, 2.5.19, 3.0.13
• Component/s: Static compilation
• Assignee: Eric Milles
• Reporter: Daniil Ovchinnikov
• Created: 22/Jan/19 12:12
• Updated: 17/Dec/23 15:22
• Resolved: 12/Jul/22 21:52

Description

@groovy.transform.CompileStatic
def foo(a) {
    if (a instanceof Integer || a instanceof Double) {
        a.floatValue() // expected: cast to Number; actual: cast to Integer
    }
}

println foo(1d).class // CCE: java.lang.Double cannot be cast to java.lang.Integer

Issue Links

• is duplicated by: GROOVY-10668 Reference to method is ambiguous if block in "if" with "instanceof"
• is related to: GROOVY-7971 @CS flow typing incorrectly casting to map at runtime
• relates to: GROOVY-10702 STC: no error for multiple instanceof and sparse method call
• relates to: GROOVY-11250 Compilation fails when accessing getter with shortcut notation on Java class
• relates to: GROOVY-11008 incorrect type inference after (instanceof || instanceof)
• relates to: GROOVY-11014 CompileStatic & Elvis operator: Cannot assign literal value of type (java.lang.Number or java.lang.Comparable) to variable of type double
• relates to: GROOVY-11137 Improve support for union and intersection types
• links to: GitHub Pull Request #1742