[GROOVY-8806] Immutable classes break in groovy 2.5.2

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.2
• Fix Version/s: 3.0.0-alpha-4, 2.5.3
• Assignee: Paul King
• Reporter: Roberto Perez Alcolea
• Created: 21/Sep/18 19:53
• Updated: 13/Dec/18 10:05
• Resolved: 04/Oct/18 03:50

Description

We've being running tests of gradle plugins with latest gradle nightly release which upgraded to groovy 2.5.2

Since then, we've seen multiple plugins breaking with errors around immutability:

 

> Unsupported type (org.ajoberstar.grgit.Branch) found for field 'trackingBranch' while constructing immutable class org.ajoberstar.grgit.Branch.
Immutable classes only support properties with effectively immutable types including:
- Strings, primitive types, wrapper types, Class, BigInteger and BigDecimal, enums
- classes annotated with @KnownImmutable and known immutables (java.awt.Color, java.net.URI)
- Cloneable classes, collections, maps and arrays, and other classes with special handling
(java.util.Date and various java.time.* classes and interfaces)
Other restrictions apply, please see the groovydoc for ImmutableOptions for further details

 

I was wondering if this change is related to https://github.com/apache/groovy/commit/3471f55ea5839ab3c9dfa51cdca081bc7b4c020e#diff-8f745c460bc1abf332f21067b21ec551R754 

 

And also,  looks like gradle plugins that use the gradleApi and are compiled with groovy 2.4 could break with groovy 2.5 with usages like this one

Issue Links

• links to: GitHub Pull Request #803