[GROOVY-8675] GenericsUtils.PARAMETERIZED_TYPE_CACHE is static and private

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.1, 3.0.0-alpha-4, 2.6.0-alpha-5
• Assignee: Daniel Sun
• Reporter: Eric Milles
• Created: 01/Jul/18 22:34
• Updated: 26/Jul/18 04:38
• Resolved: 03/Jul/18 02:37

Description

Recently, GROOVY-8604, GROOVY-8630, et al. added PARAMETERIZED_TYPE_CACHE to GenericsUtils. This type cache is static and final with no outside interface for clearing it save the soft references. Long-lived processes (like an IDE) can run into stale class data as the type being compiled are continuously being edited/altered. And different branches may be brought in from source control. I don't think it is good practice for the runtime to cache anything in static data structures.

It's difficult to judge the usefulness of this cache since the linked JIRA tickets and commits do not mention before and after measurements. But if it is indeed beneficial, could its reference be kept somewhere non-static and passed/accessed by GenericsUtils?

Issue Links

• links to: GitHub Pull Request #765