[GROOVY-8535] FieldNode constructor appears to call setType incorrectly

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.15
• Fix Version/s: 2.5.6, 3.0.0-beta-1
• Assignee: Paul King
• Reporter: Eric Milles
• Created: 06/Apr/18 19:32
• Updated: 21/Feb/19 06:18
• Resolved: 01/Feb/19 05:44

Description

If initial value expression is non-null, the first call to setType appears to have no effect.

    public FieldNode(String name, int modifiers, ClassNode type, ClassNode owner, Expression initialValueExpression) {
        this.name = name;
        this.modifiers = modifiers;
        this.type = type;
        if (this.type == ClassHelper.DYNAMIC_TYPE && initialValueExpression != null)
            this.setType(initialValueExpression.getType());
        this.setType(type);
        this.originType = type;