[GROOVY-8386] Final variable analysis broken with try/catch/finally

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.x
• Fix Version/s: 2.5.0-beta-3
• Component/s: Compiler
• Assignee: Paul King
• Reporter: Paul King
• Created: 19/Nov/17 12:25
• Updated: 27/Feb/20 11:04
• Resolved: 24/Dec/17 06:37

Description

In this code:

final begin
try {
  begin = new Date()
} finally {
  println 'done'
}

The current error is:

The variable [begin] may be uninitialized

But this should only happen if begin is used in the catch or finally blocks or prior to the first assignment.

This impacts Spock usage since it converts the following into something similar to above:

@Grab('org.spockframework:spock-core:1.1-groovy-2.4-SNAPSHOT')
@GrabExclude('org.codehaus.groovy:groovy-all')
import spock.lang.Specification

class DummySpec extends Specification {
    def 'FVA when using Spock'() {
        given:
        final begin = new Date()

        cleanup:
        println 'done'
    }
}

Issue Links

• links to: GitHub Pull Request #646