Uploaded image for project: 'Groovy'
  1. Groovy
  2. GROOVY-8298

Slow Performance Caused by Invoke Dynamic

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.4.12
    • Fix Version/s: 3.0.0-rc-3
    • Component/s: None
    • Labels:
      None

      Description

      I have been researching a problem my application is having where performance seems to be much slower than I would expect. After a lot of research I found GROOVY-6583 which seems to have the same symptoms (though not caused by the same method calls). After more research I found someone who reported a similar issue and created a sample application which reproduces the issue. I am seeing the same behavior he discusses which is that using the JIT probe I'm able to see that our production application is constantly uses a large amount of CPU on JIT activities for days on end, it never gets better.

      When doing a thread dump of our application we often see 20-50 threads all stuck on this same stack trace:

      "qtp2078714399-360525": running, holding [771bcf60]
      	at java.lang.invoke.MethodHandleNatives.setCallSiteTargetNormal(Native Method)
      	at java.lang.invoke.CallSite.setTargetNormal(CallSite.java:258)
      	at java.lang.invoke.MutableCallSite.setTarget(MutableCallSite.java:154)
      	at org.codehaus.groovy.vmplugin.v7.Selector$MethodSelector.doCallSiteTargetSet(Selector.java:909)
      	at org.codehaus.groovy.vmplugin.v7.Selector$MethodSelector.setCallSiteTarget(Selector.java:969)
      	at org.codehaus.groovy.vmplugin.v7.IndyInterface.selectMethod(IndyInterface.java:228)
      	at java.lang.invoke.LambdaForm$DMH/1665404403.invokeStatic_L3IL5_L(LambdaForm$DMH)
      	at java.lang.invoke.LambdaForm$BMH/1828868503.reinvoke(LambdaForm$BMH)
      	at java.lang.invoke.LambdaForm$reinvoker/1917025677.dontInline(LambdaForm$reinvoker)
      	at java.lang.invoke.LambdaForm$MH/462773420.guard(LambdaForm$MH)
      	at java.lang.invoke.LambdaForm$MH/1947020920.linkToCallSite(LambdaForm$MH)
      

      No matter how long the application runs it will continue to show this behavior. From what I've read I think our code causes this problem because we run code that looks like this:

      // List of objects will consistent of 2-20 instances of classes 
      // which all implement the same interface which defines the runMethod. 
      // Each concrete implementation will have it's own unique behavior
      def resultList = listOfObjects*.runMethod()
      

      Turning off invoke dynamic compilation and using the regular groovy-all jar seems to eliminate the issue and result it overall better performance.

      It would be nice if Groovy could at least identify this situation and prevent itself from getting in to the de-opt storm.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                daniel_sun Daniel Sun
                Reporter:
                jjathman Joseph Athman
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 5h 50m
                  5h 50m