[GROOVY-8262] GrabAnnotationTransformation.visit has unreachable code

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.4.13
• Assignee: Paul King
• Reporter: Eric Milles
• Created: 18/Jul/17 15:59
• Updated: 06/Mar/18 23:25
• Resolved: 19/Jul/17 01:54

Description

GrabAnnotationTransformation.visit at about line 260 has an else block that is unreachable. I think the second predicate mval == null should be removed from the if condition. This should give a more appropriate error message if an attribute is given with an empty or null value.

                            if (member == null || mval == null) {
                                addError("The missing attribute \"" + s + "\" is required in @" + node.getClassNode().getNameWithoutPackage() + " annotations", node);
                                continue grabResolverAnnotationLoop;
                            } else if (mval == null) {
                                addError("Attribute \"" + s + "\" has value " + member.getText() + " but should be an inline constant String in @" + node.getClassNode().getNameWithoutPackage() + " annotations", node);
                                continue grabResolverAnnotationLoop;
                            }