[GROOVY-8193] TraitReceiverTransformer does not set source position on property expressions

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.4.12
• Component/s: xforms
• Assignee: John Wagenleitner
• Reporter: Eric Milles
• Created: 17/May/17 17:08
• Updated: 06/Mar/18 23:14
• Resolved: 20/May/17 16:43

Description

Two paths in TraitReceiverTransformer.transform create PropertyExpression nodes to stand in for unresolved variable references. Neither case sets the exp source position onto the new node. Other paths through this method transfer position info.

The fix is simple:

            } else if (accessedVariable instanceof PropertyNode) {
                String propName = accessedVariable.getName();
                if (knownFields.contains(propName)) {
                    return createFieldHelperCall(exp, weavedType, propName);
                } else {
                    // GRECLIPSE edit
                    PropertyExpression pe =
                    /*return*/ new PropertyExpression(
                            new VariableExpression(weaved),
                            accessedVariable.getName()
                    );
                    pe.getProperty().setSourcePosition(exp);
                    return pe;
                    // GRECLIPSE end
                }
            } else if (accessedVariable instanceof DynamicVariable) {
                // GRECLIPSE edit
                PropertyExpression pe =
                /*return*/ new PropertyExpression(
                        new VariableExpression(weaved),
                        accessedVariable.getName()
                );
                pe.getProperty().setSourcePosition(exp);
                return pe;
                // GRECLIPSE end
            }

Issue Links

• links to: GitHub Pull Request #542