[GROOVY-8169] StaticCompilationVisitor.visitForLoop sets Parameter origin type, which prevents access to original source type and location

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.8, 3.0.0-beta-3
• Component/s: Static compilation
• Assignee: Daniel Sun
• Reporter: Eric Milles
• Created: 27/Apr/17 20:21
• Updated: 12/Aug/19 12:55
• Resolved: 30/Jul/19 09:13

Description

StaticCompilationVisitor.visitForLoop has call to forLoop.getVariable().setOriginType(componentType). I think this call is unnecessary as the inferred type is set on the previous line. By replacing the origin type, it is no longer possible to determine the uninferred type of the parameter or the source location of the ClassNode. Additionally, I think the semantics of origin type is not being preserved by overwriting the value.

Example:

@CompileStatic
def m() {
  List<String> strings = ...
  for (String s in strings) {
  }
}

In this example, the second occurrence of String is replaced in the AST by the first and so the source position of the ClassNode after "for" and before "s" is lost.

Issue Links

• links to: GitHub Pull Request #975