[GROOVY-8166] Repeated operations in AnnotationCollectorTransform and Traits

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.4.12
• Assignee: John Wagenleitner
• Reporter: Eric Milles
• Created: 25/Apr/17 16:19
• Updated: 06/Mar/18 23:14
• Resolved: 20/May/17 15:03

Description

I think there are a couple bits of redundant code that I have run into looking at some stuff related to traits and type checking.

1) In org.codehaus.groovy.transform.trait.Traits.isTrait(ClassNode), the check for the Trait annotation appears redundant to the call to isAnnotatedWithTrait.

2) In org.codehaus.groovy.transform.AnnotationCollectorTransform.makeListOfAnnotations(Object[][]), the recent addition of copyMembers appears to have missed removing the following line toAdd.getMembers().putAll(generated);. Thus I think the map generated is being asked to put the same entries twice.

Issue Links

• links to: GitHub Pull Request #543