[GROOVY-8069] Annotation based logging of complex expression in closure throws GroovyCastException when statically compiled

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.8
• Fix Version/s: 2.4.9
• Component/s: Static compilation
• Assignee: Shil Sinha
• Reporter: Shil Sinha
• Created: 02/Feb/17 06:34
• Updated: 08/Mar/17 08:17
• Resolved: 02/Feb/17 14:35

Description

Example:

@groovy.util.logging.Log
@groovy.transform.CompileStatic
class Foo {
    void bar() {
        def callable = {
            log.info('a' + 1)
        }
        callable.call()
    }
}
new Foo().bar()

The log statement in the code above results in the following runtime exception:

org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast object 'Foo@14ec4505' with class 'Foo' to class 'java.util.logging.Logger'

The case where the closure is in a static method is similar; the object being cast to a Logger is a Class instead.

This appears to be due to the implicitThis field being set incorrectly on the guard method call expression (log.isLoggable(Level) in the default case) created in implementations of LoggingStrategy.wrapLoggingMethodCall.

Prior to Groovy 2.4.8, log statements inside closures were not guarded (https://issues.apache.org/jira/browse/GROOVY-6932), so this bug wasn't visible.

Issue Links

• links to: GitHub Pull Request #487