[GROOVY-7992] Sort methods that accept a comparator should accept Comparator<? super T> (fix type checker ability to cope with super in DGM methods)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.7
• Fix Version/s: 4.0.7, 3.0.20
• Component/s: groovy-jdk
• Assignee: Eric Milles
• Reporter: Mauro Molinari
• Created: 06/Nov/16 23:46
• Updated: 11/Dec/23 18:15
• Resolved: 10/Dec/22 17:32

Description

Methods like org.codehaus.groovy.runtime.DefaultGroovyMethods.sort(Iterable<T>, boolean, Comparator<T>) and all the others alike should be changed to accept a Comparator<? super T>, otherwise if you use @CompileStatic you'll get compiler errors as soon as you try to sort an Iterable/Collection using a comparator that accept superclass instances.

Issue Links

• is a clone of: GROOVY-7976 Sort methods that accept a comparator should accept Comparator<? super T> (fix DGM signatures)
• relates to: GROOVY-9803 Static type checker forgets nested generic types
• relates to: GROOVY-9998 Wildcards with a lower bound fail static type checking
• relates to: GROOVY-9762 Wrong type resolved if method reference used with typed method
• links to: GitHub Pull Request #1779