Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
2.4.7
-
None
Description
Using a class constant (static final field) in an annotation causes compile errors. This works in Java and the fix is pretty small.
Ex:
class C { public static final String VALUE = 'rawtypes' @SuppressWarnings(VALUE) def method() { } }
This is a bit contrived to be concise. But we have examples in our code where Callable impls are tagged with a name, which is defined as a static constant on each class.
The fix appears to be pretty minor. In ResolveVisitor.transformInlineConstants, a case for VariableExpression does the trick for me.
} else if (exp instanceof VariableExpression) { VariableExpression ve = (VariableExpression) exp; if (ve.getAccessedVariable() instanceof FieldNode) { FieldNode fn = (FieldNode) ve.getAccessedVariable(); if (!fn.isEnum() && fn.isStatic() && fn.isFinal() && fn.getInitialValueExpression() instanceof ConstantExpression) { return fn.getInitialValueExpression(); } } ....
Attachments
Issue Links
- links to