[GROOVY-7969] Incorrect modifers on setter for volatile property with @Bindable/@Vetoable

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.4.8
• Assignee: Paul King
• Reporter: Paul King
• Created: 11/Oct/16 11:53
• Updated: 01/Feb/17 23:18
• Resolved: 13/Oct/16 07:29

Description

As part of GROOVY-3726 we fixed getter/setter method modifiers for volatile (or transient) properties. The @Bindable and @Vetoable transforms however generate their own setters and bypass that fix.

Here is a script to reproduce the problem:

import static java.lang.reflect.Modifier.toString
import groovy.beans.Bindable

class Foo {
  volatile Date now
}

@Bindable class Bar {
  volatile Date then
}

void pretty(int mod) { println "${mod.toString().padRight(10)}" + toString(mod) }

pretty(Foo.getMethod('getNow').modifiers)
pretty(Foo.getMethod('setNow', Date).modifiers)
pretty(Bar.getMethod('getThen').modifiers)
pretty(Bar.getMethod('setThen', Date).modifiers)

which currently produces:

1         public
1         public
1         public
65        public volatile

Issue Links

• links to: GitHub Pull Request #448