[GROOVY-7951] MethodCallExpression.transformExpression does not copy generic types - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.4.7
Fix Version/s: 2.4.8
Component/s: ast builder
Labels:
None

Description

org.codehaus.groovy.ast.expr.MethodCallExpression.transformExpression(ExpressionTransformer) is not copying generics info. Downstream visitors are unable to check generics on static calls like Collections.<String>emptyList().

My patched version:

    public Expression transformExpression(ExpressionTransformer transformer) {
        MethodCallExpression answer =
            new MethodCallExpression(transformer.transform(objectExpression), transformer.transform(method), transformer.transform(arguments));
        answer.setSafe(safe);
        answer.setSpreadSafe(spreadSafe);
        answer.setImplicitThis(implicitThis);
        // GRECLIPSE add
        answer.setGenericsTypes(genericsTypes);
        // GRECLIPSE end
        answer.setMethodTarget(target);
        answer.setSourcePosition(this);
        answer.copyNodeMetaData(this);
        return answer;
    }