[GROOVY-7951] MethodCallExpression.transformExpression does not copy generic types

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.7
• Fix Version/s: 2.4.8
• Component/s: ast builder
• Assignee: John Wagenleitner
• Reporter: Eric Milles
• Created: 28/Sep/16 21:58
• Updated: 01/Feb/17 23:19
• Resolved: 13/Oct/16 05:14

Description

org.codehaus.groovy.ast.expr.MethodCallExpression.transformExpression(ExpressionTransformer) is not copying generics info. Downstream visitors are unable to check generics on static calls like Collections.<String>emptyList().

My patched version:

    public Expression transformExpression(ExpressionTransformer transformer) {
        MethodCallExpression answer =
            new MethodCallExpression(transformer.transform(objectExpression), transformer.transform(method), transformer.transform(arguments));
        answer.setSafe(safe);
        answer.setSpreadSafe(spreadSafe);
        answer.setImplicitThis(implicitThis);
        // GRECLIPSE add
        answer.setGenericsTypes(genericsTypes);
        // GRECLIPSE end
        answer.setMethodTarget(target);
        answer.setSourcePosition(this);
        answer.copyNodeMetaData(this);
        return answer;
    }

Issue Links

• links to: GitHub Pull Request #441