[GROOVY-7941] MissingMethodException should limit argument types in getMessage()

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.4.7
• Fix Version/s: 2.5.0-alpha-1
• Component/s: groovy-jdk
• Environment: All Environments
• Assignee: Paul King
• Reporter: Vlad Shtibin
• Created: 15/Sep/16 23:14
• Updated: 02/May/17 02:03
• Resolved: 21/Sep/16 20:13

Description

The getMessage() method in MissingMethodException uses InvokerHelper.toTypeString(Object[] arguments) to generate the types of each argument. When this exception occurs with a large parameter list this can create a very large String. The format method which is used 2 lines later to print the values uses a 40 character limit, I'd like to propose to use similar logic for the types as well.

Here is a trivial code snippet from groovysh - this log message can grow unbounded:

groovy:000> missing(*("Test".getBytes()))
ERROR groovy.lang.MissingMethodException:
No signature of method: groovysh_evaluate.missing() is applicable for argument types: (java.lang.Byte, java.lang.Byte, java.lang.Byte, java.lang.Byte) values: [84, 101, 115, 116]
Possible solutions: toString(), toString()

Issue Links

• links to: GitHub Pull Request #426