[GROOVY-7822] Redundant computation in ObservableSet

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.6
• Fix Version/s: 2.4.7
• Component/s: groovy-runtime
• Flags: Patch
• Assignee: John Wagenleitner
• Reporter: John Wagenleitner
• Created: 21/Apr/16 02:29
• Updated: 03/Jun/16 20:16
• Resolved: 23/Apr/16 04:43

Description

There appears to be redundant computaions in "ObservableList.retainAll"
methods in version 2.4.6. I have attached a test and proposed a small
patch which ensures that "contains" method is called on hashset of
input collection. This patch gives 1739X speed up on my
machine for the provided test.

Also, one more possibility to fix the issue is by using TreeSet as suggested in
https://issues.apache.org/jira/browse/GROOVY-5739 as well.
Similar patches can be applied for three other methods, ObservableList.removeAll, ObservableSet.retainAll, ObservableSet.removeAll.

Issue Links

• is a clone of: GROOVY-7783 Redundant computation in ObservableList