Groovy
  1. Groovy
  2. GROOVY-7810

XmlSluper default constructor documentation about namespace aware incorrect.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.6
    • Fix Version/s: 2.4.7
    • Component/s: None
    • Labels:
      None
    • Flags:
      Patch

      Description

      Here is the current implementation of XmlSlurper's default constructor as of 2.4.6:

          /**
           * Creates a non-validating and non-namespace-aware <code>XmlSlurper</code> which does not allow DOCTYPE declarations in documents.
           *
           * @throws ParserConfigurationException if no parser which satisfies the requested configuration can be created.
           * @throws SAXException for SAX errors.
           */
          public XmlSlurper() throws ParserConfigurationException, SAXException {
              this(false, true);
          }
      

      It clearly creates a namespace-aware slurper.

        Activity

        Hide
        ASF GitHub Bot added a comment -

        GitHub user gillius opened a pull request:

        https://github.com/apache/groovy/pull/305

        GROOVY-7810 fix XmlSlurper default ctor doc

        Javadoc for default constructor says it creates a non-namespace-aware slurper, when it creates a namespace-aware one.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/gillius/incubator-groovy patch-1

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/groovy/pull/305.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #305


        commit 0d3e0cffe45978fab0d296b518d23574a474cb88
        Author: Jason Winnebeck <gillius@gillius.org>
        Date: 2016-04-05T20:11:31Z

        GROOVY-7810 fix XmlSlurper default ctor doc

        Javadoc for default constructor says it creates a non-namespace-aware slurper, when it creates a namespace-aware one.


        Show
        ASF GitHub Bot added a comment - GitHub user gillius opened a pull request: https://github.com/apache/groovy/pull/305 GROOVY-7810 fix XmlSlurper default ctor doc Javadoc for default constructor says it creates a non-namespace-aware slurper, when it creates a namespace-aware one. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gillius/incubator-groovy patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/305.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #305 commit 0d3e0cffe45978fab0d296b518d23574a474cb88 Author: Jason Winnebeck <gillius@gillius.org> Date: 2016-04-05T20:11:31Z GROOVY-7810 fix XmlSlurper default ctor doc Javadoc for default constructor says it creates a non-namespace-aware slurper, when it creates a namespace-aware one.
        Hide
        ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/groovy/pull/305

        Show
        ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/305
        Hide
        John Wagenleitner added a comment -

        Merged PR, thanks!

        Show
        John Wagenleitner added a comment - Merged PR, thanks!

          People

          • Assignee:
            Unassigned
            Reporter:
            Jason Winnebeck
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development