[GROOVY-7751] CallableStatement leak in Sql.call() method

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.5
• Fix Version/s: 2.4.7
• Component/s: SQL processing
• Assignee: John Wagenleitner
• Reporter: Alexey Vladykin
• Created: 09/Feb/16 19:21
• Updated: 11/Mar/16 03:01
• Resolved: 11/Mar/16 03:01

Description

All Sql.call(...) methods ultimately delegate to Sql.callWithRows(...) method where we have:

try {
    statement = connection.prepareCall(sql);
    // ...
} finally {
    // ...
    closeResources(connection, statement);
}

The problem is that statement is unconditionally parsed and compiled each time, but the closeResources() method only closes it when statement caching is disabled. So with statement caching enabled we end up allocating and leaking a new CallableStatement instance per Sql.call() invocation.