[GROOVY-7652] Float/Double trunc methods perform rounding for negative values

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.5
• Fix Version/s: 2.4.6
• Component/s: groovy-jdk
• Assignee: Pascal Schumacher
• Reporter: John Wagenleitner
• Created: 31/Oct/15 21:44
• Updated: 22/Feb/16 20:48
• Resolved: 01/Nov/15 09:12

Description

The trunc methods on Float/Double use the Math.floor method for all values, however for negative values this causing rounding. I think for negative values Math.ceil needs to be used.

Here are some asserts to show the rounding:

Float f = -123.739f
Double d = -123.739d

assert -123f == f.trunc() // fails: -124
assert -123d == d.trunc() // fails: -124

assert​ -123.73f == f.trunc(2)​ // fails: -123.74
assert -123.73d == d.trunc(2) // fails: -123.73​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​