[GROOVY-7629] ObjectRange methods duplicate functionality and should not rely on size()

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.5.0-alpha-1
• Component/s: groovy-jdk
• Assignee: Paul King
• Reporter: Thibault Kruse
• Created: 14/Oct/15 13:36
• Updated: 02/May/17 02:03
• Resolved: 28/Jun/16 09:34

Description

The methods iterator(), step(), get(), size() and subList() all step through the range, all having their own stepping implementation, which makes the class more complex than it needs to be.

Also, get(), subList() and iterator() rely on method size(), which in non-numeric cases does a brute-force iteration over all elements. This causes an unnecessary performance overhead in several cases (even if the value of size() is cached after first computation). The overhead may be arbitrarily large, and in cases the size() exceed MAX_INTEGER, the reliance leads to errors.

(Also see GROOVY-2972, GROOVY-5426).

I suggest unifying the stepping semantics and not relying on size(). PR will follow.

Issue Links

• links to: GitHub Pull Request #143