[GROOVY-7583] Unnecessary Instantiation on DefaultGroovyMethods.numberAwareCompareTo

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.5
• Fix Version/s: 2.4.6
• Assignee: Pascal Schumacher
• Reporter: Thibault Kruse
• Created: 08/Sep/15 12:57
• Updated: 22/Feb/16 20:48
• Resolved: 01/Nov/15 09:43

Description

in numberAwareCompareTo()

        NumberAwareComparator<Comparable> numberAwareComparator = new NumberAwareComparator<Comparable>();
        return numberAwareComparator.compare(self, other);

The code inside NumberAwareComparator.compare can be static, so there is no need to create a new Instance of the Comparator every numberAwareCompareTo is called. I suggest extracting the logic into a public static method, and to use that, or anything similar.