[GROOVY-7440] Improve ClosureParam type hints for various splitEachLine GroovyMethod methods

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.0-alpha-1
• Assignee: Paul King
• Reporter: Paul King
• Created: 30/May/15 01:23
• Updated: 02/May/17 02:03
• Resolved: 31/May/15 11:37

Description

Currently, the splitEachLine extension methods in different files have slightly different type hints:

NioGroovyMethods:        @ClosureParams(value = FromString.class, options = "List<String>")
StringGroovyMethods:     @ClosureParams(value = FromString.class, options = "List<String>")
IOGroovyMethods:         @ClosureParams(value = FromString.class, options = "List<String>")
ResourceGroovyMethods:   @ClosureParams(value=SimpleType.class, options="java.lang.String[]")

The List<String> variant is the best match but the type checker is smart enough to handle some vararg cases too, so the following is actually better:

@ClosureParams(value=FromString.class,options={"List<String>","String[]"},conflictResolutionStrategy=PickFirstResolver.class)