[GROOVY-7281] IOGroovyMethods.withStream should use the stream type as the ClosureParam, not simply InputStream

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.0
• Fix Version/s: 2.4.2
• Component/s: groovy-jdk
• Flags: Patch
• Assignee: Cédric Champeau
• Reporter: Craig
• Created: 27/Jan/15 21:41
• Updated: 05/Apr/15 14:44
• Resolved: 11/Mar/15 13:27

Description

IOGroovyMethods.withStream currently defines the closure parameter as InputStream. If withStream is used on a subclass of InputStream, then that type information isn't available.

Here's an example that should compile, but does not:

new ByteArrayInputStream(new byte[5]) .withStream{ final ByteArrayInputStream stream  ->
}

In IOGroovyMethods, I suggest changing the method declaration from:

public static <T> T withStream(InputStream stream, @ClosureParams(value=SimpleType.class, options="java.io.InputStream") Closure<T> closure) throws IOException {

to:

public static <T, U extends InputStream> T withStream(U stream, @ClosureParams(value=FirstParam.class) Closure<T> closure) throws IOException {