[GROOVY-7267] avoid hashcode based equality check without equals

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.3.10, 2.4.1
• Component/s: groovy-jdk
• Assignee: Jochen Theodorou
• Reporter: Jochen Theodorou
• Created: 23/Jan/15 05:40
• Updated: 24/Sep/15 20:23
• Resolved: 23/Jan/15 06:37

Description

This is a follow-up issue on GROOVY-4101 and GROOVY-4124. I think there was a misunderstanding back then. Basically this code

assert ([[1:2],[2:3]]-[["b":"a"]]) == [[1:2],[2:3]]

can fail, because of the path that is taken with NumberAwareComperator. The hashcodes of the minus element first list entry and the hashcode of the source list first element are equal. Since they are both lists DefaultTypeTransformation.compareTo will fail and the hashcode equality is then used to decide that [1:2] is to be removed. This makes not really sense, thus the issue is for the removal of the equality case