[GROOVY-7151] groovyc should accept meta annotation with ElementType.TYPE

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.0-beta-3
• Fix Version/s: 2.5.0-alpha-1
• Component/s: Compiler
• Flags: Patch
• Assignee: Cédric Champeau
• Reporter: Marcin Zajaczkowski
• Created: 04/Nov/14 16:55
• Updated: 02/May/17 02:03
• Resolved: 12/Mar/15 03:51

Description

groovyc fails on a try to annotate Groovy annotation with an annotation with Target set to TargetType.TYPE.

@Target({ElementType.TYPE})
@Retention(RetentionPolicy.RUNTIME)
@Documented
public @interface Import {
    Class<?>[] value();
}

@Target(ElementType.TYPE)
@Retention(RetentionPolicy.RUNTIME)
@Import(CorrelationIdConfiguration.class)
public @interface EnableCorrelationId {
}

EnableCorrelationId.groovy: 12: Annotation @org.springframework.context.annotation.Import is not allowed on element ANNOTATION
 @ line 12, column 1.
   @Import(CorrelationIdConfiguration.class)
   ^

The same works for Java annotations what follows Java Language Specification:

Type declarations: class, interface, enum, and annotation type declarations (§8.1.1, §9.1.1, §8.5, §9.5, §8.9, §9.6)

Corresponds to java.lang.annotation.ElementType.TYPE

Additionally, annotation type declarations correspond to java.lang.annotation.ElementType.ANNOTATION_TYPE

This is very common in Spring (Boot) application when @Import annotation (which has ElementType.TYPE) is used.

I fixed that and will make a PR in a few minutes (with proper JIRA ticket ID).

Issue Links

• is duplicated by: GROOVY-7803 Java annotation with @Target(TYPE) on an annotation