[GROOVY-6705] Compiler Doesn't Enforce Required Annotation Attributes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.9
• Component/s: Compiler
• Labels: annotations breaking
• Assignee: Unassigned
• Reporter: Jeff Brown
• Created: 14/Apr/14 14:54
• Updated: 22/Dec/23 11:38
• Resolved: 03/Sep/23 14:43

Description

I don't know if this is the same as GROOVY-3454 or not. That issue is marked resolved but I am seeing the problem with 2.1.9.

Code from the attached app...

src/main/java/com/demo/MyAnnotation.java

package com.demo;

import java.lang.annotation.ElementType;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;

@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.FIELD)
public @interface MyAnnotation {
    String value();
    String code() default "";
}

src/test/groovy/com/demo/MyAnnotationSpec.groovy

package com.demo

class MyAnnotationSpec extends spock.lang.Specification {

    void 'test code'() {
        expect:
        Widget.getDeclaredField('name').getAnnotation(MyAnnotation).code() == 'alpha'
    }
}

class Widget {
    @MyAnnotation(code='alpha')
    String name
}

That test compiles and passes. I expected the compiler to fail on the Widget class since the annotation does not provide a value for the "value" attribute.

Am I overlooking something simple or is this broken?

Issue Links

• is duplicated by: GROOVY-5952 Groovyc doesn't check annotations for missing attributes if variable is annotated
• is related to: GROOVY-3454 Compiler should enforce that annotation value w/o default is provided