Uploaded image for project: 'Groovy'
  1. Groovy
  2. GROOVY-6704

Memory leak in ClassInfo when using MetaClasses

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.8, 2.1.9
    • Fix Version/s: 2.4.0-beta-2
    • Component/s: None
    • Labels:
      None

      Description

      I'm trying to track down a memory leak in Grails and I'm pretty sure I've discovered the root cause of the leak is in Groovy. For reference, here's the thread on the grails-dev list on this topic: http://grails.1312388.n4.nabble.com/Easily-reproducible-memory-leak-in-Grails-td4655816.html

      I also raised this issue on the groovy-dev mailing list at http://groovy.329449.n5.nabble.com/Memory-leak-in-ClassInfo-when-using-MetaClasses-td5719218.html

      The problem is that when a class is loaded, then a metaclass is assigned, then the class is no longer reachable, the metaclass remains in memory. When this happens many times, lots of metaclasses are leaked, which becomes a significant problem. I discovered this problem because this how Grails implements GSPs - by loading the GSP as a groovy class, then when the GSP changes, loading a new class. The old class is unreachable, except for some internal Groovy structures... hence the memory leak.

      Attached there is a junit test that reproduces this problem: LeakTest.groovy

      Eventually, that results in an OutOfMemoryError. Using a tool like visualvm, it is clear that the number of classes constantly rises, none are ever unloaded, and the permgen keeps getting used. The heap also rises. In my tests, it usually dies after about 5,000 iterations.

      In my opinion, this shouldn't happen - this test case should run without leaking memory. Groovy should allow the MetaClasses to be garbage collected once the Class is no longer referenced by anything else. In other words, Groovy should hold a weak reference to the MetaClass/ClassInfo/etc for the Class based on the reachability of the Class.

      By taking a heap dump in visualvm, I found that there are lots of instances of org.codehaus.groovy.runtime.metaclass.MetaMethodIndex$Entry.

      The problem areas (that are GC roots) seem to be:
      org.codehaus.groovy.reflection.ClassInfo's static field modifiedExpandos
      org.codehaus.groovy.reflection.ClassInfo's static field globalClassSet

      The classes that area created by classLoader.parseClass also stick around, which is why the permgen is leaking.

      Can someone please help me determine how to fix this problem in Groovy?

        Attachments

        1. CVTest.java
          0.7 kB
          Craig
        2. LeakTest.groovy
          2 kB
          Craig
        3. MyClassValue.java
          0.3 kB
          Craig

          Issue Links

            Activity

              People

              • Assignee:
                blackdrag Jochen Theodorou
                Reporter:
                candrews Craig
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: