Groovy
  1. Groovy
  2. GROOVY-6145

Groovysh could allow filename completion inside strings

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.0-beta-1
    • Component/s: Groovysh
    • Labels:
      None
    • Environment:
      Any

      Description

      While working with Groovysh on File management tasks, it would help if the tab completion would complete filenames and path used within Strings, such as in

      f = new File('~/local/

        Activity

        Thibault Kruse created issue -
        Show
        Thibault Kruse added a comment - Reference https://github.com/groovy/groovy-core/pull/180
        Pascal Schumacher made changes -
        Field Original Value New Value
        Summary Groovysh could allow Filename completioninside Strings Groovysh could allow filename completion inside strings
        Hide
        Pascal Schumacher added a comment - - edited

        Merged. Thanks for the pull request.

        Note: The current version doesn't work with absolute filenames on Windows, but maybe this will be fixed after updating to jline 2. I will update this issue after https://github.com/groovy/groovy-core/pull/181 with the jline update is merged.

        Show
        Pascal Schumacher added a comment - - edited Merged. Thanks for the pull request. Note: The current version doesn't work with absolute filenames on Windows, but maybe this will be fixed after updating to jline 2. I will update this issue after https://github.com/groovy/groovy-core/pull/181 with the jline update is merged.
        Pascal Schumacher made changes -
        Assignee Pascal Schumacher [ pschumacher ]
        Pascal Schumacher made changes -
        Fix Version/s 2.2.0-beta-1 [ 19074 ]
        Hide
        Pascal Schumacher added a comment -

        Sadly updating jline does not help.

        Show
        Pascal Schumacher added a comment - Sadly updating jline does not help.
        Hide
        Thibault Kruse added a comment -

        See: https://github.com/jline/jline2/issues/87

        Using a patched FilenameCompleter would not be that hard either. Not sure how urgent it is for you.

        Show
        Thibault Kruse added a comment - See: https://github.com/jline/jline2/issues/87 Using a patched FilenameCompleter would not be that hard either. Not sure how urgent it is for you.
        Hide
        Pascal Schumacher added a comment -

        I don't think using a patched FilenameCompleter is necessary. We can wait till jline merges you pull request and update to a new version.

        Show
        Pascal Schumacher added a comment - I don't think using a patched FilenameCompleter is necessary. We can wait till jline merges you pull request and update to a new version.
        Hide
        Pascal Schumacher added a comment -

        Pull request https://github.com/groovy/groovy-core/pull/203 introduced a custom FileNameCompleter which fixed the problem with absolute paths under Windows (and also removed the finalizing blank, see https://github.com/jline/jline2/issues/90. Thanks to Thibault for the pull request.

        Show
        Pascal Schumacher added a comment - Pull request https://github.com/groovy/groovy-core/pull/203 introduced a custom FileNameCompleter which fixed the problem with absolute paths under Windows (and also removed the finalizing blank, see https://github.com/jline/jline2/issues/90 . Thanks to Thibault for the pull request.
        Pascal Schumacher made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Paul King made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 13:32:57 UTC 2015 [ 1428240777691 ]
        Mark Thomas made changes -
        Workflow jira [ 12735057 ] Default workflow, editable Closed status [ 12746815 ]
        Mark Thomas made changes -
        Project Import Mon Apr 06 02:11:23 UTC 2015 [ 1428286283443 ]
        Mark Thomas made changes -
        Workflow jira [ 12972589 ] Default workflow, editable Closed status [ 12980410 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        31d 23h 56m 1 Pascal Schumacher 05/Jun/13 16:23
        Resolved Resolved Closed Closed
        34d 12h 18m 1 Paul King 10/Jul/13 04:42

          People

          • Assignee:
            Pascal Schumacher
            Reporter:
            Thibault Kruse
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development