[GROOVY-6127] VerifyError "Incompatible argument to function" when returning value from function after instanceof check in a function that should return Object (bug in inference base return type selection)

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.1.3
• Fix Version/s: 2.1.4
• Component/s: Static compilation
• Assignee: Cédric Champeau
• Reporter: Lari Hotari
• Created: 29/Apr/13 23:08
• Updated: 01/Jun/13 06:11
• Resolved: 30/Apr/13 09:58

Description

This code started failing after adding the "return value" after the "if (value instanceof CharSequence)" line.

This fails:

    static Object convertValueToType(Object value, Class targetType) {
        if(targetType != null && value != null && !(value in targetType)) {
            if (value instanceof CharSequence) {
                value = value.toString()
                if(value in targetType) {
                    return value
                }
            }
            try {
                if (value instanceof Number && (targetType==Long || targetType==Integer)) {
                    if(targetType == Long) {
                        value = ((Number)value).toLong()
                    } else {
                        value = ((Number)value).toInteger()
                    }
                } else if (value instanceof String && targetType in Number) {
                    String strValue = value.trim()
                    if(targetType == Long) {
                        value = Long.parseLong(strValue)
                    } else if (targetType == Integer) {
                        value = Integer.parseInt(strValue)
                    } else {
                        value = StringGroovyMethods.asType(strValue, targetType)
                    }
                } else {
                    value = new SimpleTypeConverter().convertIfNecessary(value, targetType)
                }
            } catch (e) {
                // ignore
            }
        }
        return value
    }

This works:

    static Object convertValueToType(Object passedValue, Class targetType) {
        Object value = passedValue
        if(targetType != null && value != null && !(value in targetType)) {
            if (value instanceof CharSequence) {
                value = value.toString()
                if(value in targetType) {
                    return value
                }
            }
            try {
                if (value instanceof Number && (targetType==Long || targetType==Integer)) {
                    if(targetType == Long) {
                        value = ((Number)value).toLong()
                    } else {
                        value = ((Number)value).toInteger()
                    }
                } else if (value instanceof String && targetType in Number) {
                    String strValue = value.trim()
                    if(targetType == Long) {
                        value = Long.parseLong(strValue)
                    } else if (targetType == Integer) {
                        value = Integer.parseInt(strValue)
                    } else {
                        value = StringGroovyMethods.asType(strValue, targetType)
                    }
                } else {
                    value = new SimpleTypeConverter().convertIfNecessary(value, targetType)
                }
            } catch (e) {
                // ignore
            }
        }
        return value
    }

perhaps this has something to do with inference based return type selection.