[GROOVY-6056] @Lazy(soft=true) not quite right

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.1
• Fix Version/s: 2.1.7, 2.2.0-beta-2
• Component/s: groovy-jdk
• Assignee: Tim Yates
• Reporter: Tim Yates
• Created: 15/Mar/13 11:15
• Updated: 14/Oct/13 16:53
• Resolved: 25/Jul/13 05:15

Description

As discussed in this SO question:

http://stackoverflow.com/questions/15429315/how-to-build-a-reinitializable-lazy-property-in-groovy

If you have the following class:

class MyObject {
    @Lazy(soft=true) volatile String test =  {
        //initalize with network access
        println 'init'
        Thread.sleep(1000)
        'test'
    }()
}

The generated getter is:

    public java.lang.String getTest() {
        java.lang.String res = $test?.get()
        if ( res != null) {
            return res 
        } else {
            synchronized ( this ) {
                if ( res != null) {
                    return res 
                } else {
                    res = { 
                        this.println('init')
                        java.lang.Thread.sleep(1000)
                        return 'test'
                    }.call()
                    $test = new java.lang.ref.SoftReference( res )
                    return res 
                }
            }
        }
    }

This is incorrect as I believe it is missing a $test?.get() inside the synchronized block like so:

   public java.lang.String getTest() {
        java.lang.String res = $test?.get()
        if ( res != null) {
            return res 
        } else {
            synchronized ( this ) {
                res = $test?.get()
                if ( res != null) {
                    return res 
                } else {
                    res = { 
                        this.println('init')
                        java.lang.Thread.sleep(1000)
                        return 'test'
                    }.call()
                    $test = new java.lang.ref.SoftReference( res )
                    return res 
                }
            }
        }
    }