[GROOVY-5853] wasted work in "DefaultGrailsDomainClassInjector.implementsMethod"

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.5
• Fix Version/s: 2.0.6, 2.1.0-beta-1
• Flags: Patch
• Assignee: Jochen Theodorou
• Reporter: Adrian Nistor
• Created: 18/Dec/12 12:00
• Updated: 05/Apr/15 14:44
• Resolved: 19/Dec/12 09:57

Description

The problem appears in version 2.0.5 and in revision 4cf5263.. I
attached a one-line patch that fixes it. I will also post (in the
"Comments" section) the URL for the github pull request.

In method "DefaultGrailsDomainClassInjector.implementsMethod", in the
loop over "methods", the statement
"boolean methodMatch = mn.getName().equals(methodName) && isZeroArg"
should be
"boolean methodMatch = isZeroArg && mn.getName().equals(methodName)".
The second statement avoids comparing strings when "isZeroArg" is
"false".

The code can be made even shorter and faster by having a fast exit (by
pulling "isZeroArg" out of the loop) at the beginning of the method
body; this avoids the entire method computation. While the resulting
code is more compact than the original, the patch itself is a bit
larger (deletes 3 lines, adds 2). I attached this patch
(patchFull.diff).