[GROOVY-5849] wasted work in "ClassCompletionVerifier.checkMethodForWeakerAccessPrivileges"

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.5
• Fix Version/s: 2.0.6, 2.1.0-beta-1
• Flags: Patch
• Assignee: Jochen Theodorou
• Reporter: Adrian Nistor
• Created: 17/Dec/12 15:51
• Updated: 05/Apr/15 14:43
• Resolved: 19/Dec/12 09:59

Description

The problem appears in version 1.8.4 and in revision 4cf5263.. I
attached a one-line patch (patch.diff) that fixes it. I will also
post (in the "Comments" section) the URL for the github pull request.

The entire work performed in method
"ClassCompletionVerifier.checkMethodForWeakerAccessPrivileges"
produces no result when the parameter "MethodNode mn" represents a
public method, i.e., when "mn.isPublic()" is "true". This condition
can be evaluated right at the beginning of the
"checkMethodForWeakerAccessPrivileges" method body, thus avoiding the
entire method execution.

We can have this fast exist because the method
"checkMethodForWeakerAccessPrivileges" produces results only when this
condition (in the method code):

if ((mn.isPrivate() && !superMethod.isPrivate()) ||
        (mn.isProtected() && superMethod.isPublic()))

evaluates to "true", which does not happen when "mn.isPublic()" is
"true" (i.e., when "!mn.isPrivate() && !mn.isProtected()" is "true").

I attached a second one-line patch (patchTwoCond.diff) where I use the
condition "!mn.isPrivate() && !mn.isProtected()" instead of
"mn.isPublic()", in case you prefer the longer condition.