[GROOVY-5823] wasted work in "GenericsType.GenericsTypeMatcher.compareGenericsWithBound"

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.5
• Fix Version/s: 2.0.6
• Flags: Patch
• Assignee: Jochen Theodorou
• Reporter: Adrian Nistor
• Created: 29/Nov/12 09:00
• Updated: 05/Apr/15 14:44
• Resolved: 30/Nov/12 12:38

Description

The problem appears in Groovy 2.0.5 and in revision 740ae7c.. I
attached a one-line patch (match.diff) that fixes it.

In method "GenericsType.GenericsTypeMatcher.compareGenericsWithBound",
the loop over "redirectBoundType.upperBounds" should break immediately
after "match" is set to "false". All the iterations after "match" is
set to "false" do not perform any useful work, at best they just set
"match" again to "false".

Similarly, in the same method
"GenericsType.GenericsTypeMatcher.compareGenericsWithBound", the loop
over "interfaces" should break immediately after "success" is set to
"false". I attached a separate patch (interfaces.diff) for this loop.