[GROOVY-5425] ObjectRange doesn't have BigInteger optimisation for size()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.6
• Fix Version/s: 1.8.9, 2.0.7, 2.1.1
• Component/s: groovy-jdk
• Assignee: Tim Yates
• Reporter: Tim Yates
• Created: 27/Apr/12 10:45
• Updated: 16/Feb/13 00:47
• Resolved: 05/Feb/13 06:26

Description

The ObjectRange.size() method has optimisations for BigDecimal, Integer and Long, but not BigInteger

https://github.com/groovy/groovy-core/blob/master/src/main/groovy/lang/ObjectRange.java#L262

This means that calling:

(1G..2147483647G).size()

Takes ages

Could we change:

} else if (from instanceof BigInteger || to instanceof BigInteger) {

to

} else if (from instanceof BigDecimal ||
           to   instanceof BigDecimal ||
           from instanceof BigInteger ||
           to   instanceof BigInteger ) {

To catch this?