[GROOVY-5216] groovy.sql.Sql.newInstance(Map<String, Object>) remove params

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.7.10
• Fix Version/s: 1.8.6, 2.0-beta-3, 1.7.11
• Component/s: SQL processing
• Labels: Sql.newInstance
• Environment: Windows XP SP2, JDK 1.6.0_27
• Assignee: Paul King
• Reporter: aaaia
• Created: 27/Dec/11 07:34
• Updated: 12/Feb/12 04:03
• Resolved: 13/Jan/12 22:41

Description

method groovy.sql.Sql.newInstance(Map<String, Object>) can be nicely used with ConfigSlurper, the problem is that it removes parameters from method call argument, so source code:

def res = new ConfigSlurper().parse(new File('resource/Resources.groovy').toURI().toURL())

files.each {
		def sql = Sql.newInstance(res.db)
		//do something
		sql.close()
}

fails on second iteration due to parameters had been removed from res.db map and param "url" can not be found

the solution may be changing args.remove to args.get in procedure groovy.sql.Sql.newInstance(Map<String, Object>)