Groovy
  1. Groovy
  2. GROOVY-5014

Syntax highlighting problem in groovy.ui.Console text editor on empty string expression entering

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.2
    • Fix Version/s: 2.2.1
    • Component/s: Groovy Console
    • Environment:
      Mandriva 2010.2 i586 and OpenSUSE 11.4 x86_64, Oracle Java SE 6 Update 26

      Description

      Any input of an expression with empty string (see the attachments) does invalid syntax highlighting.

      1. GroovyConsole2.png
        14 kB
        Dmitry Ovchinnikov
      2. GroovyConsole.png
        14 kB
        Dmitry Ovchinnikov
      3. GroovyConsole.png
        15 kB
        Dmitry Ovchinnikov
      4. defective_highlight_of_empty_single_quoted_string.png
        32 kB
        Pascal Schumacher

        Activity

        Hide
        Guillaume Delcroix added a comment -

        The problem in the first place is that the code you entered is not correct.
        How would you want it to be highlighted?

        Show
        Guillaume Delcroix added a comment - The problem in the first place is that the code you entered is not correct. How would you want it to be highlighted?
        Hide
        Paul King added a comment - - edited

        Isn't it OK? Both examples run fine. The first highlights OK for me but not the second.

        Show
        Paul King added a comment - - edited Isn't it OK? Both examples run fine. The first highlights OK for me but not the second.
        Hide
        Dmitry Ovchinnikov added a comment - - edited

        The new expression 'println("" + "hello")' must not highlight fine anywhere.

        Show
        Dmitry Ovchinnikov added a comment - - edited The new expression 'println("" + "hello")' must not highlight fine anywhere.
        Hide
        Pascal Schumacher added a comment -

        The empty double quoted example was fixed sometime, but for empty single quoted strings the highlighting is still incorrect.

        Show
        Pascal Schumacher added a comment - The empty double quoted example was fixed sometime, but for empty single quoted strings the highlighting is still incorrect.
        Hide
        Pascal Schumacher added a comment -

        Submitted a pull request for this.

        Show
        Pascal Schumacher added a comment - Submitted a pull request for this.
        Hide
        Pascal Schumacher added a comment -

        pull request merged

        Show
        Pascal Schumacher added a comment - pull request merged

          People

          • Assignee:
            Pascal Schumacher
            Reporter:
            Dmitry Ovchinnikov
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development