[GROOVY-4816] Visiting Empty expressions

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 3.0.0-rc-1
• Component/s: Compiler
• Assignee: Unassigned
• Reporter: Andrew Eisenberg
• Created: 06/May/11 16:09
• Updated: 11/Nov/20 02:01
• Resolved: 27/Nov/19 16:15

Description

We are trying to integrate some parts of the Groovy-Eclipse patch on the Groovy compiler back into the compiler itself. One such change is this.

In GroovyCodeVisitor, there is no method to visit empty expressions. For consistency, we should be visiting every kind of expression.

Please add this to GroovyCodeVisitor:

void visitEmptyExpression(EmptyExpression expression); 

and this to EmptyExpression inside of the otherwise empty visit method:

visitor.visitEmptyExpression(this);

I realize that this would break classes that currently implement GroovyCodeVisitor, but this is an inconsistency in your AST visitor pattern. So I am not sure of the best way to proceed.