[GROOVY-4703] Improve FactoryBuilderSupport exception messages

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.8-rc-2, 1.9-beta-1
• Flags: Patch
• Assignee: Hamlet D'Arcy
• Reporter: Hamlet D'Arcy
• Created: 03/Mar/11 00:26
• Updated: 05/Apr/15 14:43
• Resolved: 03/Mar/11 00:26

Description

FactoryBuilderSupport exception messages could be improved in checkValueIsType() and checkValueIsTypeNotString().

Today the messages read: "The value of argument 'foo' must be of type Bar."
This doesn't tell the user what the input was that caused the failure.
A better message is: "The value of argument 'foo' must be of type Bar. Found: Baz"

This is an easy change to make, and cannot cause a NPE or anything like that.