[GROOVY-4675] Prefer ClassHelper.make(Class) over new ClassNode(Class)

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.8-rc-1, 1.9-beta-1
• Flags: Patch
• Assignee: Guillaume Sauthier
• Reporter: Cédric Champeau
• Created: 11/Feb/11 18:13
• Updated: 05/Apr/15 14:44
• Resolved: 17/Feb/11 13:51

Description

Following the discussion at http://groovy.329449.n5.nabble.com/Question-about-ClassNode-tp3382159p3382159.html, here's a patch fixing the direct calls to ClassNode(Class). All tests pass but :

in VariableExpressionTest#testIsDynamicTypedExplicitObject, we have the following code :

        VariableExpression intExpression = new VariableExpression("foo", new ClassNode(Object.class));
        assertFalse(intExpression.isDynamicTyped());

Replacing new ClassNode(Object.class) with ClassHelper.OBJECT_TYPE would cause the test to fail because ClassHelper.OBJECT_TYPE and ClassHelper.DYNAMIC_TYPE share the same reference.

2d, I had to alter the immutable annotation test because ClassHelper.make includes generic type information where new ClassNode() didn't. It does not change the logic though.