[GROOVY-4492] Bug in groovy.util.GroovyScriptEngine isSourceNewer() results in gratuitous recompilations and lost of static state in groovlets

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.5
• Fix Version/s: 1.7.6, 1.8-beta-3
• Component/s: Groovlet / GSP
• Environment: Bug is independent of OS and JVM. I'm running Ubuntu 10.10 with OpenJDK 1.6.0_18.
• Assignee: Guillaume Sauthier
• Reporter: Timur Tleukenov
• Created: 28/Oct/10 07:33
• Updated: 15/Dec/10 16:57
• Resolved: 29/Oct/10 01:47

Description

isSourceNewer() method in groovy.util.GroovyScriptEngine does evaluate script sources for recompilation (it will return true) in cases where 'nextPossibleRecompilationTime >= lastMod'. This is wrong and results in gratuitous recompilations of scripts.

An ugly side effect of this bug is, that groovlet state (static objects kept in a static class) is being lost between incoming requests, due to gratuitous recompilation and subsequent restart of groovlets.

The attached patch fixes the issue.