[GROOVY-4457] generic type declarations leaking across all files in a build

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.7.5
• Fix Version/s: 1.8.5, 2.0-beta-2, 1.7.11
• Component/s: Compiler
• Assignee: Cédric Champeau
• Reporter: Andy Clement
• Created: 04/Oct/10 17:21
• Updated: 24/Dec/11 03:08
• Resolved: 09/Dec/11 03:03

Description

Simple file, A.groovy:

class A<String> {
}

class B {
  void foo(String s) {}
}

groovyc A.groovy
javap -private B | grep foo

produces:

public void foo(java.lang.Object);

The 'String' is treated as a type parameter name. The reference 'String' in the foo method is mapped to this type parameter (clearly it shouldn't be) and when producing the code, String is erased to its upper bound of Object, hence foo(Object) in the bytecode.

Change it to this:

class A<T> {
}

class B {
  void foo(String s) {}
}

and it produces what you expect:

 public void foo(java.lang.String);

The problem is the genericParameterNames collection in the ResolveVisitor is never cleared, only augmented with new entries.

My solution that seems to work in groovy eclipse is to clear the parameter names at the end of visiting a classnode in ResolveVisitor. So at the end of

public void visitClass(ClassNode node) {

add

genericParameterNames.clear();