[GROOVY-4346] Set isSynthetic()/setSynthetic() behaviour right for AST nodes

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.8-beta-1
• Component/s: class generator
• Assignee: Unassigned
• Reporter: Roshan Dawrani
• Created: 31/Jul/10 04:00
• Updated: 03/Jan/22 03:12

Description

Currently there is no relation between the very interdependent properties - synthetic of AnnotatedNode and modifiers of various sub-classes like MethodNode, FieldNode, etc - which means that if the developer remembers to call one but forgets another, it leaves the AST in an inconsistent state. It can have synthetic == true but modifiers with SYNTHETIC bit off and vice versa.

This leads to issues at various places currently because fields, methods, classes that were intended to be synthetic don't necessarily get marked so in the bytecode.

For the nodes that have modifiers, isSynthetic()/setSynthetic()/setModifiers() should all be in sync - only based on modifiers value behind the scenes.

Issue Links

• is depended upon by: GROOVY-8495 GroovyObject method implementations are marked with ACC_SYNTHETIC