[GROOVY-4266] CLONE -Wrong generation of import statements in stubs

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.3
• Fix Version/s: 4.0.0
• Component/s: Stub generator / Joint compiler
• Environment: Windows XP, Sun JDK 1.6.0_19
• Flags: Patch
• Assignee: Eric Milles
• Reporter: Dmytro Rud
• Created: 27/Jun/10 02:45
• Updated: 03/Feb/22 22:35
• Resolved: 10/Jan/22 15:07

Description

NOTE: Below is fixed, this issue is for tracking additional impots added at end of other imports, e.g. import java.io.*;

---

Single-type import declarations in Groovy files are collected/converted into type-on-demand import declarations by the stub compiler – in other words,

import my.package.Type1
import my.package.Type2

becomes

import my.package.*;

This breaks the type shadowing mechanisms described in Section 7.5.1 of the Java Language Specification (3rd edition) and leads to Java compiler errors like "cannot decide which of the classes to use".

Moreover, current implementations is based on an unordered set, thus destroying the order of import declarations.

Attached patch solves these issues by preserving both the form and the order of original import declarations.